|
From: | Michael Goffioul |
Subject: | Re: MSVC compiler support [patch 10]: .oct file compilation |
Date: | Wed, 18 Oct 2006 14:35:39 +0200 |
User-agent: | Thunderbird 1.5.0.7 (Windows/20060909) |
John W. Eaton a écrit :
On 17-Oct-2006, Michael Goffioul wrote:| Oct files needs a different set of compilation flag, to switch from | dllexport to dllimport.| To achieve this, I compile oct-objects in a different oct/ subdirectory. I think that instead of doing this, you should write a new pattern rule that applies only to a particular list of targets. For example, like this: $(DLD_OBJ) : %.o : %.cc ... rule that applies to $(DLD_OBJ) here ... ifdef CXXPICFLAG $(DLD_PICOBJ) : %.o : %.cc ... rule that applies to $(DLD_OBJ) here ... endif Since these rules will only be used in src/Makefile.in, I think they can be defined there instead of in Makeconf.in.
The attached patch is even simpler and seems to work OK. It shouldn't change anything on other systems. Michael.
Index: src/Makefile.in =================================================================== RCS file: /cvs/octave/src/Makefile.in,v retrieving revision 1.417 diff -c -r1.417 Makefile.in *** src/Makefile.in 13 Oct 2006 18:11:27 -0000 1.417 --- src/Makefile.in 18 Oct 2006 12:33:53 -0000 *************** *** 264,269 **** --- 267,275 ---- lex.o parse.o __gnuplot_raw__.o pic/lex.o pic/parse.o pic/__gnuplot_raw__.o: \ ALL_CXXFLAGS := $(filter-out -Wold-style-cast, $(ALL_CXXFLAGS)) + $(DLD_PICOBJ): \ + ALL_CXXFLAGS := $(filter-out $(XTRA_CXXDEFS), $(ALL_CXXFLAGS)) + XERBLA = ../libcruft/blas-xtra/xerbla.o ifdef FPICFLAG PIC_XERBLA = ../libcruft/blas-xtra/pic/xerbla.o
[Prev in Thread] | Current Thread | [Next in Thread] |