[Octave-bug-tracker] [bug #54219] Dynamic detection of JVM on macOS

[John W. Eaton]

Follow-up Comment #16, bug #54219 (project octave):

I haven't been following this development, but it seems you are moving the
run_command_and_return_output function that is currently static in toplev.cc
to a separate file and putting it in the octave::sys namespace.

I don't see where you are removing the old function.

I think this new code could also just go in the octave namespace.

oct-process.{h,cc} is probably OK.  I agree it should go in liboctave unless
it uses something from libinterp.

For now, my advice on copyright is:

Since some of this code is coming from an existing file, it should probably
have the same copyright as that file.  You are adding code, so you can also
add a line for your name and use the current year.

Longer term, I may have different advice about how we should manage copyright
notices in Octave, but that deserves a discussion among the developers
somewhere else, not just in the comments of a bug report.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?54219>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/