[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #54922] demo surfl 1 fails
From: |
Rik |
Subject: |
[Octave-bug-tracker] [bug #54922] demo surfl 1 fails |
Date: |
Sun, 4 Nov 2018 09:46:21 -0500 (EST) |
User-agent: |
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0 |
Update of bug #54922 (project octave):
Status: Patch Submitted => Fixed
Open/Closed: Open => Closed
_______________________________________________________
Follow-up Comment #9:
@Markus: Thanks for the patch. I reviewed and pushed it here
(https://hg.savannah.gnu.org/hgweb/octave/rev/50583f514ae4).
I simplified the __update_normals__ function by removing some of the input
validation. There wasn't a need to use ishghandle, for example, because the
next line was
graphics_object go = gh_manager::get_object (val);
If val was not a proper handle then this will not return a valid
graphics_object and the subsequent tests for go.isa ("XXXX") will fail and the
default else clause
error ("__update_normals__: "
"H must be a handle to a valid surface or patch object.");
will eventually be taken.
I also aligned tests in if () conditionals for better readability. Instead
of
if (force || ((facelighting_is ("flat") || edgelighting_is ("flat")) &&
get_do_lighting ()))
I used
if (force || ((facelighting_is ("flat") || edgelighting_is ("flat"))
&& get_do_lighting ()))
Marking as fixed and closing report.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?54922>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/