[Octave-bug-tracker] [bug #54882] fail to build with Qt 4.8: class QPointer<> has no member named 'clear'

[Mike Miller]

URL:
  <https://savannah.gnu.org/bugs/?54882>

                 Summary: fail to build with Qt 4.8: class QPointer<> has no
member named 'clear'
                 Project: GNU Octave
            Submitted by: mtmiller
            Submitted on: Mon 22 Oct 2018 02:05:46 PM PDT
                Category: Configuration and Build System
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Build Failure
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: GNU/Linux

    _______________________________________________________

Details:

In Qt 4.8, the QPointer class template does not have a method named 'clear'.

The following change (not yet tested) should be backwards compatible and
equivalent:


--- a/libgui/src/octave-cmd.cc
+++ b/libgui/src/octave-cmd.cc
@@ -178,7 +178,7 @@ namespace octave
             cmd_gp->execute (interp);
           }
 
-        cmd_gp.clear ();    // remove the original cmd pointer
+        cmd_gp = nullptr;    // remove the original cmd pointer
       }
 
     if (repost)  // queue not empty, so repost event for further processing


Torsten, since you wrote the change that added a call to QPointer<>::clear,
can you test or verify that this change is safe and equivalent to your
intentions?




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?54882>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/