[Octave-bug-tracker] [bug #50820] [octave forge] (signal) pwelch incorrectly discards DC component

[STPR]

Follow-up Comment #16, bug #50820 (project octave):

John: I noticed that as well, but for the time being I did not focus on
optimising existing code; just get all the features to work. If you are happy
with my changes to the code, pwelch now is completely compatible with MATLAB,
barring few tests. 

1) Yes, fft() pads zero as required and we really do not require that before
hand.
2) I was going to go for reshape as well initially, it was really a flip of a
coin for this one. I just needed something that worked.
3) I cannot think of any case where it would make sense to subtract 3.
Speaking of which, we should include a sanity check to make sure the specified
size or window vector does not exceed the signal size.
4) I am currently not sure how MATLAB enforces short vector size, I have to
test it out next time I am in the university. But on top of my head, I think
that there should at least be 3 elements for shifting/onesided PSD to work
properly. 

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?50820>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/