[Octave-bug-tracker] [bug #54391] Incorrect result when attempting to type or paste UTF-8 Cyrillic text into octave CLI

[Mike Miller]

Follow-up Comment #10, bug #54391 (project octave):

On the contrary, I think the Meta-N and Meta-P key bindings in
liboctave/util/cmd-edit.cc are not working at all, and maybe haven't been for
quite a long time, and no one noticed.

The readline library itself binds Meta-N and Meta-P to the functions
'non-incremental-forward-search-history' and
'non-incremental-reverse-search-history', respectively. When these functions
are activated, the input shows a ':' prompt, the user types some search
string, presses Enter, and the first history substring match is recalled.

This is very different from the functions that Octave is attempting to bind
Meta-N and Meta-P to. In cmd-edit.cc, the keys are bound to
'history-search-forward' and 'history-search-backward', respectively. When
these functions are called, whatever the user has already typed in the input
buffer is used as the substring search term.

When I run an unpatched Octave, built with readline 7, Meta-N and Meta-P give
me the readline built in behavior, not the behavior that Octave intended with
the bindings in cmd-edit.cc. So I agree that these can be safely deleted
because they are not effective with a current version of readline.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?54391>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/