[Octave-bug-tracker] [bug #50820] [octave forge] (signal) pwelch incorrectly discards DC component

[John W. Eaton]

Follow-up Comment #4, bug #50820 (project octave):

I would like to work on updating pwelch to match the current interface and
calculations done by the same function in Matlab's signal processing toolbox.

What would be your preference for backward compatibility?  I see a couple of
possibilities:

1. Throw out all the complications of handling old Matlab behavior and target
the latest interface.

2. Same as 1, but also keep the existing function as old_pwelch (or
something).  If someone really wants the old behavior, they can copy this
function file to a directory in their personal path.

3. Keep the old function and automatically forward to it if someone has set
the internal "compatib" variable.  Otherwise, just try to match current
behavior.  This approach seems friendlier at minimal cost.  I would further
mark the old code as unmaintained and make no promise for attempting to update
it.  It seems to me that the new code will be easier to maintain if we don't
attempt to mix in the old in the same function file.

Comments and suggestions?  I can begin working on the compatible interface and
argument processing code and identify any computations that need to be added
or updated to match current behavior.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?50820>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/