[Octave-bug-tracker] [bug #54256] [octave forge] (ltfat) package fails to cross compile with mxe-octave

[John W. Eaton]

Follow-up Comment #3, bug #54256 (project octave):

I see the following message in the log/of-ltfat file when I build with a
patched configure script.  I'm simply changing MKOCTFILE_CHECK to be
MKOCTFILE, regenerating the configure script with autoconf, and creating a
patch file for the of-ltfat package.


checking for mkoctfile...
/scratch/build/mxe-octave-w32/usr/bin/i686-w64-mingw32-mkoctfile --verbose
configure: error: Please install mkoctfile.


I jumped to the wrong conclusion.  The problem is not just that
MKOCTFILE_CHECK is used instead of MKOCTFILE, but also that the
"valie-if-found" argument for AC_CHECK_PROG is "yes", and then the subsequent
test results in an error if the value of "$MKOCTFILE_CHECK" is "yes".  Oops.

I think a better test would be:


dnl Check for MKOCTFILE
AC_CHECK_TOOL(MKOCTFILE,mkoctfile)
if test -z "$MKOCTFILE"; then
    AC_MSG_ERROR([Please install mkoctfile.])
fi


This will respect MKOCTFILE set in the environment.

If not, it will automatically use the cross tool prefix if cross compiling
(CHECK_TOOL instead of CHECK_PROG).

It fixes the logic of the test for mkoctfile not being available.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?54256>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/