[Octave-bug-tracker] [bug #53578] pkg: uninstall fails if tar/zip contents are read-only (make distcheck fails in pkg.tst)

[Mike Miller]

URL:
  <http://savannah.gnu.org/bugs/?53578>

                 Summary: pkg: uninstall fails if tar/zip contents are
read-only (make distcheck fails in pkg.tst)
                 Project: GNU Octave
            Submitted by: mtmiller
            Submitted on: Fri 06 Apr 2018 03:45:37 PM PDT
                Category: Octave Function
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Unexpected Error
                  Status: Confirmed
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: GNU/Linux

    _______________________________________________________

Details:

If a package tar or zip contains files or directories that are marked
read-only when the package distribution is created, maybe only directories,
then 'pkg uninstall foo' fails with an error


couldn't delete directory /path/to/.../mfile_basic_test-0.1.0: Permission
denied


In particular, when running 'make distcheck', the test suite is run from a
read-only copy of the Octave source. This leads to 4 out of 10 test failures
in pkg.tst.

IMHO, if pkg install works, then pkg uninstall must be able to undo whatever
pkg install did. That means if the contents of the package were made
restrictive in some way, either

1. pkg install must change permissions as necessary when
unpacking/creating/copying, or
2. pkg uninstall must be able to delete things regardless of file
permissions.

Also a test for this specific error should be added to pkg.tst. For example,
create a copy of one of the minimal package directories in test/pkg,
recursively chmod files and directories, and do an install/uninstall test.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53578>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/