[Octave-bug-tracker] [bug #46444] [octave forge] (signal) buttord, cheb1ord, cheb2ord : different errors

[Mike Miller]

Update of bug #46444 (project octave):

                  Status:         Patch Submitted => Patch Reviewed         

    _______________________________________________________

Follow-up Comment #3:

As with bug #45811, thank you very much for your work on this contribution,
this is an excellent functional improvement, and the demonstration scripts are
very helpful as well. I am sorry that it has taken a couple of years for me to
get around to reviewing it properly.

I will be spending some time on integrating your ellipord changes from bug
#45811. If you are willing to spend some more time on this, it would be
helpful to reduce the amount of integration work I will have to do on this bug
report. Some of the changes that are necessary include

* use Octave coding style ('endif' instead of 'end', spaces around operators,
etc, see https://wiki.octave.org/Octave_style_guide)

* turn the demonstration scripts into proper %!demo blocks for use with the
'demo' function

* each function now has one failing test, update the test suite for the
corresponding changes in the allowed arguments

In general, the easiest kind of submission like this would be a 'diff -u'
patch of each function file, with tests and demos integrated into the function
files to work with Octave's 'test' and 'demo' commands.

If you don't want to spend any more time on this, then I can do the
integration work myself, as I have already started doing on bug #45811, but it
may take some time.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46444>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/