[Octave-bug-tracker] [bug #52940] Regression with "PaperPosition" and printing

[Dan Sebald]

Follow-up Comment #14, bug #52940 (project octave):

Question: At the start of __opengl_print__() is a drawnow() call:


function opts = __opengl_print__ (opts)

  dos_shell = (ispc () && ! isunix ());

  set (0, "currentfigure", opts.figure);
  drawnow ("expose");


Any recollection why that is done?  I remove it and no longer does the FLTK
graphics toolkit go through the on-screen contortions.  However, the FLTK PDF
output then doesn't look correct (right edge is missing).  I'm just wondering
why this can't be taken care of inside drawnow() so that it only needs to be
called once when wanting the EPS/PDF output.

Commenting out that drawnow() doesn't affect the QT toolkit; the Qt window
still goes through the contortions.  Probably there is some redundant action
going on with Qt, i.e., draw on-screen twice then draw to file.

@Rik, I'm attaching a changeset that removes some old comments about "remove
after we are certain the fix works".  I checked the Mercurial record and those
comments are over a year old.  I hope things are stable in that regard.  Even
if not, an arbitrary wait time to cover up some bug is not a good fix, so I'd
hope that octave_sleep() call wouldn't be re-implemented.

(file #43037)
    _______________________________________________________

Additional Item Attachment:

File name: octave-drawnow_fixme_comment_removal-djs2018jan23.patch Size:1 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52940>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/