[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #52380] lower/upper functions should pass any
From: |
Rik |
Subject: |
[Octave-bug-tracker] [bug #52380] lower/upper functions should pass any numeric value? |
Date: |
Fri, 5 Jan 2018 01:29:57 -0500 (EST) |
User-agent: |
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 |
Update of bug #52380 (project octave):
Status: Confirmed => Patch Reviewed
_______________________________________________________
Follow-up Comment #4:
@Stevie: I modified your changeset slightly. Octave follows the GNU coding
guidelines for commit messages which are a one-line summary (which you had)
followed by a per file/per function explanation of what was changed. I added
the second bit. We also try, when we're being good, to use test-driven
development. So I wrote BIST tests for toupper and tolower and included them
in mappers.cc (where the two functions reside). I then compiled and ran
octave:1> test mappers.cc
***** assert (tolower (single (68i)), single (68i))
!!!!! test failed
tolower: not defined for float complex scalar
which proves why tests are important. Apparently the float scalar case in
ov-flt-complex.cc is missing.
I uploaded the most recent version of your cset so you can patch it to work
for all possible inputs.
(file #42841)
_______________________________________________________
Additional Item Attachment:
File name: 52380.cset Size:3 KB
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?52380>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Octave-bug-tracker] [bug #52380] lower/upper functions should pass any numeric value?,
Rik <=