octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #52706] Rewrite xpow.cc using templates


From: Rik
Subject: [Octave-bug-tracker] [bug #52706] Rewrite xpow.cc using templates
Date: Fri, 22 Dec 2017 17:50:18 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

Update of bug #52706 (project octave):

                Priority:              5 - Normal => 3 - Low                
              Item Group:    Matlab Compatibility => Feature Request        
                  Status:         Patch Submitted => Confirmed              
                 Summary: mpower compatibility behavior => Rewrite xpow.cc
using templates

    _______________________________________________________

Follow-up Comment #7:

xpow.cc is a mess.  It seems to have been written before widespread use of
templates and there is a lot of code duplication.

I applied your patch here
(http://hg.savannah.gnu.org/hgweb/octave/rev/4827cbef0949).  In addition, I
wrote a templated version of xisint and used Octave coding syntax for
indexing.

The whole file should really be re-written with templates, and to make use of
xelem () for faster access to array elements.  In addition, using
octave_quit() in the innermost loop is overkill.  In liboctave there are
examples where the inner loop runs 4 times before calling octave_quit().  That
could be done here as well.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52706>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]