[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #50153] image package: bwperim result on 1x1 i
From: |
Carnë Draug |
Subject: |
[Octave-bug-tracker] [bug #50153] image package: bwperim result on 1x1 input incorrect |
Date: |
Mon, 27 Mar 2017 13:06:14 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 |
Follow-up Comment #7, bug #50153 (project octave):
The proposed patch would error on the cases where connectivity is just [0 0 0;
0 1 0; 0 0 0]. A very corner case but it hints that the issue is not 1x1
image. I think the issue is more generalised about not considering border
elements in dimensions of length 1. This alternative patch
https://bitbucket.org/carandraug/octave-image/commits/c2a397b5bd8c65d8e2122ee5b7bf9eea874254a9
seems to fix the original issue plus several new ones (such as image of
`true(1, 1, 6)`) This just removes a check that was just wrong. But maybe the
check was there for some reason that we have no test for. I think the test
was just wrong (mea culpa) so if no one can see anything wrong with it, I will
push that cset.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?50153>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Octave-bug-tracker] [bug #50153] image package: bwperim result on 1x1 input incorrect,
Carnë Draug <=