octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #45088] image package: rangefilt requires doma


From: Hartmut
Subject: [Octave-bug-tracker] [bug #45088] image package: rangefilt requires domain and image to have equa number of dimensions
Date: Wed, 28 Dec 2016 23:22:50 +0000 (UTC)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0

Follow-up Comment #9, bug #45088 (project octave):

I've tested Avinoam's patch "rangefilt2.diff" from comment #8:

* There is a semicolon misssing after the new code line with padarray.

* The patched version of rangefilt.m still supports Nd input images. (see
comment #6).

* The example (with a full white rgb-color input image to rangefilt.m ) from
comment #0 works fine with this patch applied. But to judge if this usecase of
ndims(I) > ndims(domain) would work fine in general, I would like to know the
Matlab result of the following:


R = [1:5] .* ones(5,1);
G = R+1;
B = R*2;
I = cat(3, R, G, B)
J = rangefilt(I)


* The opposite usecase (mentioned at the end of comment #6) is not dealt with,
yet. Carne suggested "If the domain has more dimensions, then the extra
dimensions can be removed." But I would like to argue that this usecase is
less realistic then my original one, discussed above. The original issue
mostly arises because the default value of "domain" is 2d (even with images of
higher dimension).


So if the patched version of rangefilt also gives Matlab compatible results on
the new test code above, I would suggest to commit this (sligthly corrected)
patch to the image repo, close this issue, and do the total rewrite of
rangefilt (using imdilate) lateron.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?45088>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]