[Octave-bug-tracker] [bug #48505] build does not use any warning options in libgui/qterminal

[Mike Miller]

URL:
  <http://savannah.gnu.org/bugs/?48505>

                 Summary: build does not use any warning options in
libgui/qterminal
                 Project: GNU Octave
            Submitted by: mtmiller
            Submitted on: Wed 13 Jul 2016 03:29:04 PM PDT
                Category: Configuration and Build System
                Severity: 2 - Minor
                Priority: 5 - Normal
              Item Group: Feature Request
                  Status: Confirmed
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: Any

    _______________________________________________________

Details:

Octave's configure script sets some default compiler options in the variables
$(CXXFLAGS), $(AM_CXXFLAGS), and $(XTRA_CXXFLAGS), as well as some gcc warning
options in the variable $(WARN_CXXFLAGS).

The top-level Makefile.am does


AM_CXXFLAGS = $(XTRA_CXXFLAGS)


and then every subdirectory does its own


foo_CXXFLAGS = $(AM_CXXFLAGS) $(WARN_CXXFLAGS)


This seems pretty redundant and wasteful, so I tried to simplify this by just
adding the WARN_ flags to the AM_ flags at the top and eliminating all of the
unnecessary foo_CXXFLAGS. The end result is that all the flags end up being
the same, but we are intentionally omitting warning flags from the
libgui/qterminal subdirectory.

The qterminal code (that we imported from somewhere else) contains many many
warnings that our default flags would catch, including

* 836 counts of -Wold-style-cast
* 15 counts of -Wunused-variable
* 7 counts of -Wcast-qual
* 6 counts of -Wshadow
* 1 count of -Wunused-parameter

This is not a huge priority, and maybe we leave it as it is now, but good to
remember that there is potentially buggy code in the qterminal directory, and
maybe we can fix it or maybe we replace the entire command window
implementation before that happens.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?48505>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/