[Octave-bug-tracker] [bug #47503] geometry package: remove use of deprecated octave_config_info

[Carnë Draug]

URL:
  <http://savannah.gnu.org/bugs/?47503>

                 Summary: geometry package: remove use of deprecated
octave_config_info
                 Project: GNU Octave
            Submitted by: carandraug
            Submitted on: Wed 23 Mar 2016 02:27:06 GMT
                Category: Octave Forge Package
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: None
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: other
        Operating System: Any

    _______________________________________________________

Details:

The PKG_ADD and PKG_DEL packages in the geometry package access details form
octave_config_info in case they are installed in the arch dependent directory.
 However, this package no longer has oct files so it's no longer necessary.

Even, if there were oct files in the geometry package, a better solution is a
private function with PKG_ADD directives to call itself.  The attached patch
also does it.

In addition, it seems to me that the PKG_ADD (and PKG_DEL) files have an extra
code for the case of being used in testing (instead of properly installed via
pkg).  However, the recommended way to test the package should be via its
Makefile "make run".  I have also modified the Makefile to check for the
presence of PKG_ADD directives.

Finally, I have further reduce the code by keeping the whole logic in a single
place and only changing the addpath/rmpath based on a binary call to the
binary package.

This solution should make the geometry easier to maintain (and also no longer
dependent on the deprecated octave_config_info).



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 23 Mar 2016 02:27:06 GMT  Name: replace_PKG_files.cset  Size: 7kB  
By: carandraug

<http://savannah.gnu.org/bugs/download.php?file_id=36731>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47503>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/