[Octave-bug-tracker] [bug #44095] readline configuration - tab autocompletion of paths

[Lachlan Andrew]

Follow-up Comment #22, bug #44095 (project octave):

Thanks for the feedback, John.  I've made the easy changes, and attempted the
other ones.  In particular:

1. I don't think I added any char* functions to the command_editor class.  The
only char* function I added was gnu_readline::do_completer_word_break_hook(). 
The quoting functions such as


char *gnu_readline::command_quoter (char *text, int matches, char *qcp)


also return char *.  To avoid any confusion, I've made the function not a
member of any class.  Let me know if there is something else you had in mind.

2. To me, a filename is the last component of a path (unless that path is to a
directory).  Still, I replaced "path" by "filename" in the code.  Is that what
you wanted?

3. I've avoided the malloc by writing an accessor function to Readline's
variable, which is cleaner anyway.

Sorry that I don't know how to produce a changeset based on what in my
repository are two commits.  I'm providing a diff instead.  Once you're happy
with it, I'll figure out how to produce a changeset :)

(file #35833)
    _______________________________________________________

Additional Item Attachment:

File name: bug_44095.v3.diff              Size:5 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?44095>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/