[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #46106] ode45: FSAL property not used, solver
|
From: |
Carlo de Falco |
|
Subject: |
[Octave-bug-tracker] [bug #46106] ode45: FSAL property not used, solver fail if it is activated |
|
Date: |
Sat, 03 Oct 2015 05:32:20 +0000 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:41.0) Gecko/20100101 Firefox/41.0 |
Update of bug #46106 (project octave):
Status: Need Info => In Progress
_______________________________________________________
Follow-up Comment #1:
Hi,
I'm pushing the new attached patch (file #35045) which
seems to fix the issue of failing integration with FSAL.
The problem was that when a time step was rejected the solution
would be thrown away but not the "k_vals".
Here is a performance comparison with and without the
patch.
with patch:
Testsuite HIRES, testing solver ode45 with relative tolerance 1e-07
-----------------------------------------------------------------------------------------
Solver RelTol AbsTol Init Mescd Scd Steps Accept FEval JEval
LUdec Time
-----------------------------------------------------------------------------------------
ode45 1e-07 1e-07 1e-09 7.24 4.82 12334 10430 86331
26.216
-----------------------------------------------------------------------------------------
without patch:
Testsuite HIRES, testing solver ode45 with relative tolerance 1e-07
-----------------------------------------------------------------------------------------
Solver RelTol AbsTol Init Mescd Scd Steps Accept FEval JEval
LUdec Time
-----------------------------------------------------------------------------------------
ode45 1e-07 1e-07 1e-09 7.24 4.82 12334 10430 86331
30.596
-----------------------------------------------------------------------------------------
It would probably be cleaner to check for empty "k_vals"
inside the stepper rather than in the integrator, but that
would require changing other steppers that are not yet in core.
Therefore I am pushing the changeset but I'll leave the bug
open so we remember to cleanup later.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?46106>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/