[Octave-bug-tracker] [bug #45816] canonicalize_file_name() changed behavior between 3.8.2 and 4.0.0 on windows

[Mike Miller]

Follow-up Comment #21, bug #45816 (project octave):

My own 2¢: I think the include should be moved to the top, easy to search on
the same conditional showing up twice in the file rather than needing to keep
it with the conditional code. Many other parts of our baseline do it that
way.

My reading of the code for filesep is that it should be a forward slash ("/")
on cygwin.

I also see that filesep has an "all" option to return multiple separators
where it's ambiguous. This should be a string containing both forward and
backward slashes, on *both* native Windows and cygwin environments.

So I think the recommendation would be for functions that need to parse path
strings to use filesep("all") as the delimiter (see the fileparts.m function
file). I'll copy this to the dependent bug as well for the geometry package.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?45816>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/