|
From: | Carnë Draug |
Subject: | [Octave-bug-tracker] [bug #45196] gallery: raises error when calling randsvd, pei, kms, hanowa, gearmat. |
Date: | Wed, 27 May 2015 16:23:28 +0000 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 Iceweasel/31.7.0 |
Follow-up Comment #1, bug #45196 (project octave): The test blocks seem wrong. What are they supposed to be doing? Could you change the code in qmult to follow our coding guidelines? Brackets around conditions, space after function name and before parentheses (no space if it's indexing a variable). The commit message also needs to follow our guidelines http://wiki.octave.org/Commit_message_guidelines Also, instead of adding a ! to "x <= y", you could just change the operator to ">". And in a separate commit, can the for loops in qmult be vectorized? At the least last one should be easy. _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/bugs/?45196> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |