[Octave-bug-tracker] [bug #44822] Case-sensitive listdlg's SelectionMode values

[Dan Sebald]

Follow-up Comment #4, bug #44822 (project octave):

I'll let someone with more broad knowledge of the whole project make the call
on consistency, but given uigetfile appears to have tweaked the code to first
cast things to lower case, perhaps that's what should be done here as well.

There is this 


          if (srole == "YesRole")
            erole = QMessageBox::YesRole;
          else if (srole == "NoRole")
            erole = QMessageBox::NoRole;
          else if (srole == "RejectRole")
            erole = QMessageBox::RejectRole;
          else if (srole == "AcceptRole")
            erole = QMessageBox::AcceptRole;


which uses CamelCase when not necessary, but I think I did that just because
camel case matches the Qt enumeration definitions and noncamelcase is
sometimes clumsy to read.  Also, in this case YesRole isn't something entered
by the user.

Also, in the code is the following:


//  else if ()
//    view->setSelectionMode (QAbstractItemView::ContiguousSelection);
//  else if ("Multiple")
//    view->setSelectionMode (QAbstractItemView::MultiSelection);


We can delete that, given this has been used for a while and there has been no
complaints about the way multiple selection works.  The only difference
between ExtendedSelection and MultiSelection is that extended also allows use
of the shift key for selecting everything between two entries--that is typical
behavior now days.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?44822>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/