|
From: | Pantxo Diribarne |
Subject: | [Octave-bug-tracker] [bug #42688] isdiag, isbanded, istril, istriu functions missing in Octave |
Date: | Mon, 07 Jul 2014 10:36:53 +0000 |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:30.0) Gecko/20100101 Firefox/30.0 |
Follow-up Comment #1, bug #42688 (project octave): Hi Massimiliano, I have a few remarks: * some shape validations functions like isvector, isrow ... were recently translated from .m to C++ for performance (see changeset http://hg.savannah.gnu.org/hgweb/octave/rev/4f0e4f20a33f). I wonder if the new ones you propose shouldn't have the same performance constraint. Anyways, a preliminary (or definite) .m implementation is valuable * the new functions should eventually return true only for 2 dimensional matrices (see "ndims") * in order to return a boolean, a cleaner approach would be using "all" in place of "min". _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/bugs/?42688> _______________________________________________ Message posté via/par Savannah http://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |