[Octave-bug-tracker] [bug #34301] Can't compile oct files using gcc -fvisibility=hidden option

[Mike Miller]

Update of bug #34301 (project octave):

                Priority:              5 - Normal => 3 - Low                

    _______________________________________________________

Follow-up Comment #2:

Still unable to compile Octave itself with -fvisibility=hidden, fixed the
patch to the following:


diff --git a/oct-conf-post.in.h b/oct-conf-post.in.h
--- a/oct-conf-post.in.h
+++ b/oct-conf-post.in.h
@@ -121,6 +121,14 @@
 #if defined (_MSC_VER)
 #define OCTAVE_EXPORT __declspec(dllexport)
 #define OCTAVE_IMPORT __declspec(dllimport)
+#elif defined (__GNUC__)
+#if (__GNUC__ >= 4)
+#define OCTAVE_EXPORT __attribute__ ((visibility ("default")))
+#define OCTAVE_IMPORT __attribute__ ((visibility ("default")))
+#else
+#define OCTAVE_EXPORT
+#define OCTAVE_IMPORT
+#endif
 #else
 /* All other compilers, at least for now. */
 #define OCTAVE_EXPORT


With a default build of Octave, there is no change, everything works as it
used to. So I just want to understand better what this change is actually
supposed to help with, is Octave supposed to be able to be built with hidden
symbols, or is it only for the benefit of external packages that are linking
against the Octave libraries (that still expose the full set of library
symbols in their dynamic symbol table)?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?34301>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/