[Octave-bug-tracker] [bug #41546] warning ("pinv: tol is ignored for diagonal matrices");

[Ceral Paquet]

Follow-up Comment #4, bug #41546 (project octave):

I just noticed a patch got sent to fix a bug I reported last week.

Awesome - thanks. However there's a small gotcha in the new code:

+ if (std::abs (elem (i, i)) < tol)
+ retval.elem (i, i) = 0.0;
+ else
retval.elem (i, i) = 1.0 / elem (i, i);

When tol==0 and elem(i,i)==0, the code will divide by zero. Changing < to <=
will remedy the problem but makes the behaviour inconsistent with non-diagonal
pinv function.

E.g.

q=diag([3 2 1]);
pinv([q],2) # uses non-diag code
pinv(q,2) # uses diag code

To copy from the non-diagonal pinv, we could do
[url=http://octave.sourceforge.net/doxygen/html/dd/d4d/dMatrix_8cc_source.html#l00854]this[/url]:

868  if (tol <= 0.0)
869  {
...
873  tol = nc * sigma.elem (0) * std::numeric_limits<double>::epsilon ();
874  }

where sigma.elem (0) in this case is the max abs of the diagonal elements.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?41546>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/