|
From: | Mike Miller |
Subject: | [Octave-bug-tracker] [bug #40669] rgb2ind: uses system ("gm convert....") for dither option |
Date: | Fri, 22 Nov 2013 14:02:36 +0000 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.57 Safari/537.36 |
Update of bug #40669 (project octave): Severity: 3 - Normal => 4 - Important Item Group: None => Incorrect Result Status: None => Confirmed _______________________________________________________ Follow-up Comment #1: Confirmed. I also don't have the gm executable on my system. But apparently "make check" doesn't exercise this code path because I haven't seen an error yet. Yes it would be much preferable to reimplement with magick library calls, could be added to __magick_read__.cc. Otherwise this adds an extra runtime dependency that our distributors need to know about, and this is fairly hidden. If we have to keep the current approach, it at least needs a runtime check for the executable and an appropriate error message if "gm" is not found in PATH. It also doesn't look to me like the temporary files being created are deleted at all. _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/bugs/?40669> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |