[Octave-bug-tracker] [bug #40041] change to __makeinfo__.m breaks generating help for forge packages

[Carlo de Falco]

URL:
  <http://savannah.gnu.org/bugs/?40041>

                 Summary: change to __makeinfo__.m breaks generating help for
forge packages
                 Project: GNU Octave
            Submitted by: cdf
            Submitted on: Mon 16 Sep 2013 01:37:13 PM CEST
                Category: Octave Function
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Regression
                  Status: In Progress
             Assigned to: cdf
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: Any

    _______________________________________________________

Details:

This changeset:


changeset:   17372:687872d279be
user:        Rik <address@hidden>
date:        Wed Aug 28 10:29:03 2013 -0700
summary:     __makeinfo__.m: Remove @seealso code made obsolete by cset
4e9dc46d4125.


removes the third input argument for __makeinfo__
which makes it incompatible with how this function
is used in "generate_package_html".

This problem had occurred before with this changeset:


changeset:   13120:fc0ea95fbba0
user:        Rik <address@hidden>
date:        Fri Sep 09 11:15:41 2011 -0700
summary:     __makeinfo__.m: Remove unused third input argument.


which was subsequently reverted here:


changeset:   13121:390add500107
user:        Carlo de Falco <address@hidden>
date:        Sat Sep 10 12:08:15 2011 +0200
summary:     Add back the third input parameter to __makeinfo__



How can can we fix this in a way that also prevents the problem from happening
again?
I see the following alternatives:

1 (easy) -  Revert the change and add a comment inside __makeinfo__ to remind
that the third argument is indeed used somewhere important.

2 (difficult) -  Patch the function html_help_text to work without the third
input argument.

3 (unknown difficulty) - move generate_package_html into core so that its
existence does not get forgotten.

Which one would be preferred? If no one objects I'll go for the first one
later today as it is the least time consuming.









    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?40041>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/