[Octave-bug-tracker] [bug #39722] history list adds extraneous carriage return when recalling commands

[Dan Sebald]

Follow-up Comment #3, bug #39722 (project octave):

I've printed the text that is issued via


        emit command_double_clicked ((*it).data().toString());


and the correct text is appearing in the proper order.  I believe this is a
flaw in communications between the GUI and the core:

https://savannah.gnu.org/bugs/?39723

I will bring this up on the discussion list.  I think the evaluate is correct
from the GUI's perspective.

Other than that, I think the patch does sensible things.  When a block is
copied, there is no CR added after the last line, but I think I prefer that
for use in an editor...but perhaps other would disagree.  I think that is
something we could leave temporarily to get feedback from beta-users.

We could make the following code a function:


  for (QModelIndexList::iterator it = rows.begin (); it != rows.end (); it++)
    {
      if ((*it).isValid ())
        {
          if (prev_valid_row)
            text += "n";
          text += (*it).data().toString();
          prev_valid_row = true;
        }
    }


since it is duplicated in the code.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?39722>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/