[Octave-bug-tracker] [bug #34893] conv2 produces different results for shape 'valid' depending on the orientation of matrix B

[Jordi Gutiérrez Hermoso]

Follow-up Comment #9, bug #34893 (project octave):

Thanks Marco. This is much more convenient for me to analyse and apply.

Attached is a modified version of your patch. I made the following changes:

1) The commit message has a one-line description including the number of the
bug you're squashing.

2) Individual files you touched get their changes separately enumerated. If
there a particular C or C++ function you changed, the general format is

* file.cc (class1::function1): Made change foo. (class2::function2): Made
change bar.

I omitted the parenthetical function names here because your changes aren't
inside any C or C++ function.

3) Don't use norm or max(abs(...)) or similar for the assert function The
assert function already has a 3-argument calling form for testing both
absolute and relative error, and this form produces a more informative
diagnostic when it fails.


I hope it's clear that these are improvements. The format of the commit
message is important. In source tarballs, we generate changelogs from the
commit messages using the "hg log --style changelog" command, and so the style
of the commit messages has to match accordingly.

If you agree that these changes are correct, I will push my version of the
patch. When you pull from Savannah, it will appear to you that you have a
duplicate patch in your local repository, because you will have both your
patch and my version.
I will explain later how to handle this situation.

(file #25355)
    _______________________________________________________

Additional Item Attachment:

File name: logm-2.diff                    Size:3 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?34893>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/