[Octave-bug-tracker] [bug #35570] Indexing of sparse vectors

[Jordi Gutiérrez Hermoso]

Update of bug #35570 (project octave):

                  Status:         Patch Submitted => Fixed                  
             Open/Closed:                    Open => Closed                 
                 Release:                   3.6.0 => 3.6.1                  

    _______________________________________________________

Follow-up Comment #5:

Thanks, I pushed a modified version of your patch:

http://hg.savannah.gnu.org/hgweb/octave/rev/ec660526ae50

Since this was a regression, I patched on the stable branch.

Note the following modifications over your patch:

1) The commit message is different. Short one-line description, longer
description saying the file and function in which the change is.

2) Added a test to verify the correctness of this change.

3) No tabs! For some reason, your second diff still had tabs.

4) Spaces before opening parentheses in function calls, but not in front of
indexing. You were missing a couple of spaces.

5) And it's done with hg. ;-)

If you submit future patches, please try to follow these suggestions.

Thanks again, closing this report.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?35570>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/