octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #34405] Validation for betainc() inputs


From: John W. Eaton
Subject: [Octave-bug-tracker] [bug #34405] Validation for betainc() inputs
Date: Tue, 27 Sep 2011 04:51:19 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20100101 Firefox/5.0 Iceweasel/5.0

Follow-up Comment #1, bug #34405 (project octave):

A simple fix would be to just add the checks in the betainc functions in
lo-specfun.cc that accept scalar values.  See the attached patch.

But then we are checking all inputs all the time, even when one or two are
scalars and the others are large arrays.  But before attempting to fix this in
the code that performs the loops, I think it would be better to first convert
those functions to use templates to avoid some duplication.

I can work on this if you would like, but I don't want to change the stable
branch to use templates, and I don't want to have to add the checks to all the
current functions in lo-specfun.cc.  So what do you think we should do?  Add
the simple but slow check to the stable branch, then make a better fix using
templates for the default branch?

(file #24030)
    _______________________________________________________

Additional Item Attachment:

File name: diffs.txt                      Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?34405>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]