[Octave-bug-tracker] [bug #29921] spline() should ignore NaNs

[Rik]

Follow-up Comment #1, bug #29921 (project octave):

>From your Changeset:
+  if (any (isnan (a)))
+    for k = 1:size(a,2)
+      ok = (! isnan (a(:,k)));
+      a(!ok,k) = spline (x(ok), a(ok,k), x(!ok));
+    endfor
+  endif

This will iterate over all of the columns (1:size(a,2)), including the ones
which don't have NaNs in them.  It would be more efficient to operate only on
the columns with NaNs in them.
For example:
  for k = (1:columns (a))(any (isnan (a)))
    ok = ! isnan (a(:,k));
    a(!ok,k) = spline (x(ok), a(ok,k), x(!ok));
  endfor

It is a little opaque but the key is that it creates a range from 1 to the
number of columns and then uses the isnan function to index into it so that
only columns with NaNs will get processed.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?29921>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/