[Hotp-toolkit-help] Re: Bug building libhotp on FreeBSD 7.2

[Simon Josefsson]

Kevin Quinlan <address@hidden> writes:

> Hi
>
> Just trying to find out if you hotp pam module will work for me.
>
> In building the tools on FreeBSD 7.2 downloaded from
> http://download.savannah.nongnu.org/releases/hotp-toolkit/
>
> I found that libhotp would not compile by default, as the definitions for 
> S_IRUSR and S_IWUSR are
> not in the header files referenced in usersfile.c
>
> I just added in a conditional include for /usr/include/sys/stat.h to fix this.
>
> #include <stdio.h>              /* For snprintf, getline. */
> #include <unistd.h>             /* For ssize_t. */
> #include <fcntl.h>              /* For fcntl. */
> #include <errno.h>              /* For errno. */
>
> #ifdef HAVE_SYS_STAT_H
> #include <sys/stat.h>         /* For S_IRUSR and S_IWUSR */
> #endif

Hello Kevin.  Thanks for your interest!  I have fixed this by importing
the gnulib sys_stat module instead, which allows us to unconditionally
include sys/stat.h on all platforms (after all, it is POSIX).   Should
be fixed in v1.0.1 or later releases.

/Simon