Re: [Nmh-workers] Announcing the second release candidate of nmh 1.7.1

[Ralph Corderoy]

Hi Andy,

> So it's entering this:
>
> if [ $iconv_elides_question_marks -eq 1 ]; then
>     check "$expected" "$actual"
> else
>     grep "Can't convert .*us-ascii to UTF-8" "$actual" >/dev/null  ||  
> failed=1
> fi

convert_charset() in uip/mhshowsbr.c is expected to call
iconv_open("UTF-8", "?us-ascii"), or similar, and have that return -1.
You may want to confirm they're the values passed by adding an
fprintf(stderr, ...).

I think the test could do more when it fails.  Something like

diff --git test/mhshow/test-charset test/mhshow/test-charset
index e87f0a51..e4a653a5 100755
--- test/mhshow/test-charset
+++ test/mhshow/test-charset
@@ -146,10 +146,13 @@ EOF
 run_prog mhshow $msgnum > $actual 2>&1
 if [ $iconv_elides_question_marks -eq 1 ]; then
     check "$expected" "$actual"
+elif grep "Can't convert .*us-ascii to UTF-8" "$actual" >/dev/null; then
+    :
 else
-    grep "Can't convert .*us-ascii to UTF-8" "$actual" >/dev/null  ||  failed=1
+    echo 'iconv complaint not found'
+    sed l "$actual"
+    failed=1
 fi

-- 
Cheers, Ralph.
https://plus.google.com/+RalphCorderoy