[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nmh-workers] OpenBSD added to the buildbot cluster

From: David Levine
Subject: Re: [Nmh-workers] OpenBSD added to the buildbot cluster
Date: Mon, 16 Dec 2013 22:23:17 -0500

Ken wrote:

> - Really, this overuse of strcpy/strcat results from our usage of fixed
>   sized buffers.  We should be switching to dynamically-allocated strings
>   whenever possible.  Fixing that means dealing with idea of who actually
>   owns a particular memory object and is responsible for freeing it?
>   I've been fixing up APIs I'm involved with, but it's slow going.  I'd
>   rather address these problems this way rather than do a whole audit
>   for every instance of strcpy().

Agreed.  The nmh MIME parser relies on dynamically-allocated
strings, and nicely at that.  That's much more important to me
than a bulletproof config parser and outgoing message handler.

Its memory management is pretty clear from the structs and
comments in h/mhparse.h.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]