[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nmh-workers] mhshowing a specific mime part

From: Paul Fox
Subject: Re: [Nmh-workers] mhshowing a specific mime part
Date: Sun, 09 Dec 2012 13:05:58 -0500

ken wrote:
 > >unless anyone objects today, i'll push a simple patch which causes
 > >"related" to be supported for both mhbuilding and mhparsing.  no
 > >special processing is done -- it just causes the subtype to be
 > >recognized.
 > As long as you're in there .... could you do a couple more things?  Please? 
 > :-)
 > - According to RFC 2046, if you get a multipart subtype you don't know about,
 >   you're supposed to handle it as multipart/mixed.

okay, with the patch below, my previous (unpublished) patch which
supported "multipart/related" is unnecessary.  "multipart/foobar" now
works as well.  i've pushed this, but i'd appreciate at least one
other ack that it doesn't look like it's going to break anything.

 > - Would you be willing to write tests for this stuff?  Specifically handling
 >   multipart/somerandomjunk?  If you have questions about the test suite, just
 >   feel free to ask; David Levine is probably the most up-to-date on it, but
 >   I've done some work in there as well.

i haven't gotten to this yet.


commit 298062b034bb8a0bc9583b261617bbfa3a6ec1ad
Author: Paul Fox <address@hidden>
Date:   Fri Dec 7 10:27:52 2012 -0500

    mhshow:  properly treat unknown multipart subtypes as "mixed"

diff --git a/uip/mhshowsbr.c b/uip/mhshowsbr.c
index 550669a..80fc9eb 100644
--- a/uip/mhshowsbr.c
+++ b/uip/mhshowsbr.c
@@ -655,14 +655,11 @@ show_multi (CT ct, int serial, int alternate)
        return show_multi_aux (ct, serial, alternate, cp);
-     * Use default method to display this multipart content
-     * if it is not a (nested) part of a multipart/alternative,
-     * or if it is one of the known subtypes of multipart.
+     * Use default method to display this multipart content.  Even
+     * unknown types are displayable, since they're treated as mixed
+     * per RFC 2046.
-    if (!alternate || ct->c_subtype != MULTI_UNKNOWN)
-       return show_multi_internal (ct, serial, alternate);
-    return NOTOK;
+    return show_multi_internal (ct, serial, alternate);

 > --Ken
 > _______________________________________________
 > Nmh-workers mailing list
 > address@hidden
 > https://lists.nongnu.org/mailman/listinfo/nmh-workers

 paul fox, address@hidden (arlington, ma, where it's 38.7 degrees)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]