nmh-workers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Nmh-workers] handling of long header lines by pick (bug #15215)


From: David Levine
Subject: [Nmh-workers] handling of long header lines by pick (bug #15215)
Date: Fri, 23 Nov 2012 12:01:03 -0600

https://savannah.nongnu.org/bugs/?15215
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=268744

pick currently handles multiple-line header fields by:
1) replacing each newline with a space, and
2) leaving leading whitespace on continuation lines intact.

The patch below would skip each newline in multiple-line
header fields, in order to unfold per RFC 2822.  Agreed?

The bug notes that leaving all of the leading whitespace on
continuation lines intact is inconsistent with what mh-format
does, which is to collapse into a single space.  But I think we
should leave this as-is in pick.  It's consistent with its man
page and the RFC, I think.  And it's easy enough to work around
with a regexp, as noted in the Debian bug.  Thoughts?

David


diff --git a/uip/picksbr.c b/uip/picksbr.c
index 4073919..4895b23 100644
--- a/uip/picksbr.c
+++ b/uip/picksbr.c
@@ -701,7 +701,8 @@ plist
                        break;
                    }
                    lf++;
-                   c = ' ';
+                   /* Unfold by skipping the newline. */
+                   c = 0;
                }
            }
            if (c && p1 < &linebuf[LBSIZE - 1])



reply via email to

[Prev in Thread] Current Thread [Next in Thread]