[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Nmh-workers] Possible Problem with printf in uip/mhmail.

From: Ralph Corderoy
Subject: [Nmh-workers] Possible Problem with printf in uip/mhmail.
Date: Fri, 19 Oct 2012 17:23:09 +0100


Working my way back through the parents to see what man pages were
on-going I came across some changes to the use of printf(1) in
uip/mhmail committed by David Levine.


It's a brief diff but has things like

    - -hel|-help) printf "%s\n" "${usage}"; exit ;;
    + -hel|-help) printf "${usage}\n"; exit ;;

My concern would be that $usage mustn't contain a % in the future.  Same
goes for the other changes, except with $header, etc., which are perhaps
more likely to have a %.  It could do with double-checking.  (Where does
this habit of ${foo} come from when there's no ambiguity to $foo, I find
the noise annoying.  :-)

Cheers, Ralph.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]