[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Nmh-workers] Question about trailing newline patch

From: Ken Hornstein
Subject: [Nmh-workers] Question about trailing newline patch
Date: Tue, 20 Mar 2012 10:10:29 -0400

Okay, this has been bugging me for a little while now, and it's a little
confusing.  But please follow along.

Last month I complained about messages Norman Shapiro was sending,
because they contained multiple cc: lines which technically isn't
valid according to the RFCs; these messages made repl unhappy.  Norman
happily changed his messages and life moved on, and I forgot about it.

Recently when I've been adding mh-format support to various programs,
I was staring at some of the code in replsbr.c, and I realized that
there was code in place to handle this exact situation.  Norman's
messages _should_ have worked fine.  So this made wonder why it didn't
work.  Some quick exploration with git made me realize that the following
commit broke this support:

commit 255d4c646c0d7aa6b049052fef47fa083b1b1506
Author: Oliver Kiddle <address@hidden>
Date:   Sun Jan 29 19:34:42 2006 +0000

    remove trailing newlines from components to fix bug with spaces at the end 
    Subject/References in replies

Now I don't want to seem like I'm gunning for you, Oliver.  I see what
you were trying to do.  It just so happens that this broke the code in
the next section that used the newline at the end of the component to
detect if we need to add a "," as a separator.  If we don't add that
then it's not a valid list of addresses and repl is unhappy.

I know this was six years ago, but I'm wondering if a) you remember exactly
what you were trying to solve and b) if we could fix it another way.  I
have thought about various code fixes but they all have issues.  We
have the %(trim) function available in mh-format; we could always use that


reply via email to

[Prev in Thread] Current Thread [Next in Thread]