[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nmh-workers] about mhparam

From: Valdis . Kletnieks
Subject: Re: [Nmh-workers] about mhparam
Date: Tue, 14 Dec 2010 11:46:46 -0500

On Tue, 14 Dec 2010 16:31:09 +0100, markus schnalke said:

> I improved the man page in some ways; see attached patch.
> I also spotted code that appears to be badly formated:
> --- a/uip/mhparam.c
> +++ b/uip/mhparam.c

Something that has proven to be very useful over in the Linux kernel world is
the concept of "One thing, one patch".  So this should be 2 separate patches,
one to fix the man page, and one to fix the code. The biggest reason for this
is that if it becomes necessary to revert the commit to the git tree, you
aren't reverting something unrelated along with it.

(Of course, a change to the code and matching man page updates should probably
be done as one commit).

Attachment: pgpyWwTlKew2z.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]