Re: [Nmh-workers] Updates to nmh

[Doug Porter]

Ken Hornstein <address@hidden> writes:
> 
> - All networking calls now converted to new APIs
>   (getaddrinfo(), sockaddr_storage, and the like).

I only took a quick glance, but I think there may be some issues
with freeaddrinfo() use.  For example, in sbr/client.c client() a
NULL pointer can be passed to freeaddrinfo().  That doesn't work
on a lot of platforms.  Second, it seems memory is being leaked
in that function if you get a result set from getaddrinfo(), but
fail to connect and then call getaddrinfo() again with a
different host.

Additionally, I don't know if you can assume that res will be set
to NULL if getaddrinfo() fails.  Since the spec doesn't specify,
I figure it could be in any state on error:  NULL, never changed,
or pointing at a result set.

-- 
dsp