[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nmh-workers] Proposed solution to Debian Bug#143485
From: |
Ralph Corderoy |
Subject: |
Re: [Nmh-workers] Proposed solution to Debian Bug#143485 |
Date: |
Fri, 26 Aug 2005 17:03:02 +0100 |
Hi Harald,
> > > execlp (mhlproc, mhl, "-form", filter, "-noclear", NULL);
> > > - fprintf (stderr, "unable to exec ");
> > > - perror (mhlproc);
> > > + write(2, "unable to exec ", 15);
> >
> > Reminds me of Hollerith constants, i.e. having to manually count the
> > length of a string literal. Can't we just stick with the fprintf(),
> > perror(), etc., and add judicious use of fflush()?
>
> No. fflush() won't help since stderr should be unbuffered anyway. But
> the vfork()ed child might still overwrite the parents data. Of course
> we could stick with fprintf() if we dropped vfork()...
Apologies, I obviously haven't been following closely enough; I thought
we were getting rid of vfork() calls in the patch.
Cheers,
Ralph.