[Nmh-commits] [SCM] The nmh Mail Handling System branch, master, updated. 1.7-branchpoint-232-ga27d1ec

[Ralph Corderoy]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The nmh Mail Handling System".

The branch, master has been updated
       via  a27d1ec492f69d93a13821a0f236f0691d8683a3 (commit)
       via  41c25df5a669fa999155c6d29435856ffa5bcd36 (commit)
       via  85cc92f23306d688ed9b97d0f7892410c842c447 (commit)
       via  6e613a1064f418cb3658e1e6c8aa14768816ee5c (commit)
       via  c67c38e4cb1110be80927cf11a5ce14d316c4a51 (commit)
      from  872ef4dde72a88ceb1358849a462f791135b842d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a27d1ec492f69d93a13821a0f236f0691d8683a3
Author: Ralph Corderoy <address@hidden>
Date:   Mon Sep 18 12:43:28 2017 +0100

    whom.c: Don't call rename(2) with source that's uninitialised.
    
    The intent is that two rename(2)s take place: to move a file to a
    backup and then return it.  The first test controlled the generation of
    the destination in the char array `backup' and calling the first
    rename().  The second test used that same array for the restoring
    rename(), but used a different test and so could run when the first
    rename hadn't, and with an uninitialised array for the source filename.
    
    The initialisation of `backup' and the first rename needed both
    environment variables `mhdist' and `mhaltmsg' to be non-empty, and the
    former to have a non-zero atoi(3) value.  The second rename ignored
    `mhaltmsg'.  Bug pre-dates git.

commit 41c25df5a669fa999155c6d29435856ffa5bcd36
Author: Ralph Corderoy <address@hidden>
Date:   Mon Sep 18 12:31:58 2017 +0100

    whom.c: Re-work fork/exec logic to clarify interaction with distsw.

commit 85cc92f23306d688ed9b97d0f7892410c842c447
Author: Ralph Corderoy <address@hidden>
Date:   Mon Sep 18 12:12:58 2017 +0100

    If fork(2) fails then die;  don't fall through to execve(2).
    
    It's already been agreed that failure to fork() is so rare these days
    that multiple attempts aren't required.  Nor should the code persevere
    by calling execve() as if the fork had succeeded, else why bother to
    fork?  Instead, die.

commit 6e613a1064f418cb3658e1e6c8aa14768816ee5c
Author: Ralph Corderoy <address@hidden>
Date:   Mon Sep 18 11:59:37 2017 +0100

    whom.c: Don't increment atoi(3)'s return value as it's already true.
    
    atoi(3) has returned non-zero and distsw holds that value.  Only the
    truthness of distsw matters.  Don't increment distsw, as if to show it's
    been set, because that would turn the true -1 to false 0.  Bug pre-dates
    git.

commit c67c38e4cb1110be80927cf11a5ce14d316c4a51
Author: Ralph Corderoy <address@hidden>
Date:   Mon Sep 18 11:56:26 2017 +0100

    whom.c: Don't store atoi(getenv("mhdist")) when value only tested.
    
    It's the non-zero value of atoi(3) that's important in the if-condition;
    the value is never used again.

-----------------------------------------------------------------------

Summary of changes:
 uip/rcvdist.c    |  4 ++--
 uip/send.c       |  4 ++--
 uip/whatnowsbr.c | 10 +++-------
 uip/whom.c       | 61 ++++++++++++++++++++++++++------------------------------
 4 files changed, 35 insertions(+), 44 deletions(-)


hooks/post-receive
-- 
The nmh Mail Handling System