[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Nmh-commits] [SCM] The nmh Mail Handling System branch, master, updated

From: David Levine
Subject: [Nmh-commits] [SCM] The nmh Mail Handling System branch, master, updated. 1.5-branchpoint-1086-g05dba91
Date: Sun, 02 Feb 2014 16:02:05 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The nmh Mail Handling System".

The branch, master has been updated
       via  05dba91fcb152e1941e7f7f145b1d830c5e8f6d0 (commit)
      from  f02de746f64f0879e1d8dc754293a121b686646b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 05dba91fcb152e1941e7f7f145b1d830c5e8f6d0
Author: David Levine <address@hidden>
Date:   Sun Feb 2 09:58:45 2014 -0600

    Removed all unnecessary setuid/setgid calls.  Using setuid as an
    example and not showing the setgid analogues:
        1) setuid(getuid());
        This dropped privileges before an exec and is normally a
        good thing.  Except here, the return value isn't checked.
        And, we don't have any setuid programs in nmh now, so it was
        2) if (geteuid() == 0) setuid(pw->pw_uid);
        This would have been a security hole if the executable was
        setuid root because the user specifies the source of the pw
        data.  This was in slocal(1), which is not setuid, so this
        was certainly not needed.
        3) setuid(geteuid());
        This was in post(8) for when it called the sendmail
        executable directly (-mts sendmail or -mts sendmail/pipe.
        It's not necessary with modern sendmail or replacements.


Summary of changes:
 mts/smtp/smtp.c    |    2 --
 sbr/context_save.c |    2 --
 sbr/makedir.c      |    3 ---
 uip/popsbr.c       |    3 ---
 uip/slocal.c       |   10 ----------
 5 files changed, 0 insertions(+), 20 deletions(-)

The nmh Mail Handling System

reply via email to

[Prev in Thread] Current Thread [Next in Thread]