[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Nmh-commits] [SCM] The nmh Mail Handling System branch, master, updated

From: David Levine
Subject: [Nmh-commits] [SCM] The nmh Mail Handling System branch, master, updated. 1.5-branchpoint-85-g436e6b4
Date: Thu, 14 Jun 2012 13:14:31 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The nmh Mail Handling System".

The branch, master has been updated
       via  436e6b477fa6dabe40404c84334e148b49682708 (commit)
      from  1888a6885e0c4049755578814462cad4259e85df (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 436e6b477fa6dabe40404c84334e148b49682708
Author: Alexander Zangerl <address@hidden>
Date:   Thu Jun 14 07:31:40 2012 -0500

    The base64-decoder doesn't work on 64-bit big-endian architectures:
    mhstore and co. write files of the correct length but which consist
    only of \0s.
    The culprit is uip/mhparse.c, which contains a pretty ugly base64
    decoder (in two places). that thing allocates a "long int" as a
    container for the 24 bits that you get from four base-64 chars. the
    container is then accessed both as a single entity and as a byte
    array, which naturally depends on how wide the long int is and in what
    order things end up in there.
    The code distinguishes between big- and little-endian systems but
    wrongly assumes that sizeof(long int) == 4, which isn't universally
    true (quel surprise...).
    The attached patch fixes the issue, but in the long run we should
    insist on posix and use a64l().


Summary of changes:
 uip/mhparse.c |   25 ++++++++++++++++++-------
 1 files changed, 18 insertions(+), 7 deletions(-)

The nmh Mail Handling System

reply via email to

[Prev in Thread] Current Thread [Next in Thread]