[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Nmh-commits] CVS: nmh ChangeLog,1.165,1.166

From: Jeffrey C Honig <address@hidden>
Subject: [Nmh-commits] CVS: nmh ChangeLog,1.165,1.166
Date: Sun, 10 Aug 2003 21:20:54 -0400

Update of /cvsroot/nmh/nmh
In directory subversions:/tmp/cvs-serv19427

Modified Files:
Log Message:
When compiling format strings, nmh attempts to avoid multiple parsing
of address and date fields by only inserting calls to the parse
functions (FT_PARSEADDR and FT_PARSEDATE) for a given component once.
The problem with this method is that the initial invocation may
actually be on a code path that is conditionally executed.  This can
result cached copies of data from the fields in previous messages to
be used.

My solution is to move this optimization from compile time to run time.
Address and Date parsing calls (FT_PARSEADDR and FT_PARSEDATE) will
always be included.  Run time flags are used to prevent these functions
from being run more than once per component per message.

The c_flags field has being converted from a boolean to a bit-field to
facilitate maintenance of the new CT_PARSED value.  The result value
that used to be in this field is now the bit CF_TRUE and the
overloaded use of this field by scan() is now the CT_DATEFAB bit.

Some unneeded flags (CT_ADDRPARSE, CT_MYMBOX) have also been removed.

Index: ChangeLog
RCS file: /cvsroot/nmh/nmh/ChangeLog,v
retrieving revision 1.165
retrieving revision 1.166
diff -C2 -r1.165 -r1.166
*** ChangeLog   4 Jul 2003 16:15:02 -0000       1.165
--- ChangeLog   11 Aug 2003 01:20:52 -0000      1.166
*** 1,2 ****
--- 1,11 ----
+ 2003-08-10  Jeffrey C Honig  <address@hidden>
+       * Fix problem where parsing of address/date fields in fmt_compile
+       is optimized to the first instance.  The first instance may be in
+       contitional code which will result in cached data to
+       be used.  Instead, convert c_flags to a flags field from a boolean
+       and parse on the first use.
+       * Remove some unused flag bits.
  Fri Jul 01 22:02:00 2003 Glenn Burkhardt <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]