Re: [Nano-devel] [PATCH 1/2] new thing: a tools menu that groups together some larger functions

[Brand Huntsman]

On Thu,  9 May 2019 12:05:15 +0200
Benno Schulenberg <address@hidden> wrote:

> This menu draws a prompt bar but centers the text so that it is clear
> that this is not actually a prompt.  It also leaves the cursor in the
> edit window, so the user can see where cut-till-end-of-file will start
> its cut.

global.c: In function 'shortcut_init':
global.c:1357:33: error: 'do_spell' undeclared (first use in this function); 
did you mean 'do_help'?
  add_to_sclist(MTOOLS, "^T", 0, do_spell, 0);
                                 ^~~~~~~~
                                 do_help
global.c:1357:33: note: each undeclared identifier is reported only once for 
each function it appears in
global.c:1360:33: error: 'do_full_justify' undeclared (first use in this 
function)
  add_to_sclist(MTOOLS, "^J", 0, do_full_justify, 0);



prompt.c: In function 'offer_tools':
prompt.c:795:15: error: 'do_spell' undeclared (first use in this function); did 
you mean 'do_help'?
   if (func == do_spell || func == do_linter || func == do_full_justify) {
               ^~~~~~~~
               do_help
prompt.c:795:15: note: each undeclared identifier is reported only once for 
each function it appears in
prompt.c:795:56: error: 'do_full_justify' undeclared (first use in this 
function)
   if (func == do_spell || func == do_linter || func ==
   do_full_justify) {



The ^T bind is not available without ENABLE_SPELLER.

 #ifdef ENABLE_SPELLER
-   add_to_sclist(MMAIN, "^T", 0, do_spell, 0);
+   add_to_sclist(MMAIN, "^T", 0, offer_tools, 0);
 #endif

There is no function name to rebind the tools menu in nanorc.

The "Choose a tool" should probably be left aligned. Your eye is drawn to the 
left side for other menus and this one has nothing there. It is even worse on 
really wide terminals. Maybe add a "..." on the end to differentiate it from 
other left aligned menu labels.

It looks a little odd when help bar is hidden, but forcing help on
could shift the edit window for cut-till-eof and other tools.
Maybe the nohelp M-X toggle could be bound by default in the tools menu (and 
maybe other prompts so you don't have close prompt, enable help and re-open 
prompt). And "Choose a tool... press M-X for list" could be used if help bar is 
hidden.