Re: [Nano-devel] [PATCH 1/2 V3] cutting: when ^K does not actually cut anything, do not add an undo item

[Benno Schulenberg]

Op 01-01-19 om 23:25 schreef David Ramsey:
> Benno Schulenberg:
>> I don't think it's simpler, nor clearer.  But it is longer, and would
>> necessitate a linewrap for the second condition.  also, I like the
>> rhythm of NULL, \0, NULL.
> 
> You're testing for current's being on the bottom line of the file;
> that's what filebot is for.

If that is what filebot is for, then I am all for getting rid of it.
It will save us the trouble of keeping the thing in sync.

> It's possible to forget that the mark is on if it covers no characters,
> since there's no visual indicator for it then,

If the user has truly forgotten that the mark is on, then cutting *nothing*
when the user types ^K is majorly unexpected.

> and this behavior would
> be unexpected in that case (especially since Pico doesn't act that way
> either).

We're leaving Pico behind.  Or rather: we've left Pico behind long ago.
We took from Pico what was good, and tried to improve where it wasn't.

> So this sounds like a bad idea to me.  Indicating that nothing
> gets cut in that case is much better.

Maybe.  I still think that when nothing is marked, nano should act as
when the mark is off.

Benno

signature.asc
Description: OpenPGP digital signature