Re: [Nano-devel] [PATCH V6] Implement bookmarks

[Benno Schulenberg]

Op 06-12-18 om 02:37 schreef Marco Diego Aurélio Mesquita:
> On Wed, Dec 05, 2018 at 08:26:12PM +0100, Benno Schulenberg wrote:
>> Do you have any plans to make them visible?  In the space between line
>> number and text maybe?
> 
> Yes I have plans for this. I tried not highlighting the number of
> a bookmarked line and liked it. What do you think about it?

When I use line numbers, they are colored.  When the number for a
bookmarked is uncolored... don't know if that is nice.  But it's
probably better than putting a star or some other character in the
single column between line number and text.

>> A bookmark is not visible, so setting or removing has no visual effect,
>> so there is no need to refresh the edit window.
> 
> It is needed for the case when the screen must be scrolled.

But toggling a bookmark does not move the cursor at all, so why
would the screen scroll?

> Thanks for the review! I think V7 is now commit-ready.

Commit-ready...  Oh, how eager you are.  :)

Have a look at https://savannah.gnu.org/bugs/?55054.  It has had
fifteen revisions already and still I'm not ready to commit it.
In other words: patience.

Benno

signature.asc
Description: OpenPGP digital signature