Re: [Nano-devel] [PATCH] delete a marked region or line without affecting the cutbuffer

[Brand Huntsman]

On Tue, 23 Oct 2018 17:20:13 +0200
Benno Schulenberg <address@hidden> wrote:

> > +#ifndef NANO_TINY
> 
> The #if is not needed: the whole undo code is not present in the
> tiny version.  Several more of them further down.

Thanks, it is easier to read now.


> "Let an unmodified Backspace or Delete erase the marked region without
> affecting the cutbuffer."

Fixed.


> "let Bsp and Del erase a marked region"

Fixed.


> > +   ZAP_BSP_DEL,  
> 
> I will rename this flag to "LET_THEM_ZAP".  It should be added at the
> end of the list -- that is where new flags get added.

Fixed.


> >     } else if (keystring[0] == 'M') {
> > +           if (strcasecmp(keystring, "M-Del") == 0)
> > +                   return ALT_DELETE;  
> 
> This will not be added.  The M-Del keystroke will not be rebindable,
> just like ^Del and Sh-^Del are not rebindable.  (That Del itself is
> rebindable is a leftover from the past.)

Oops, I thought that was needed for add_to_sclist() to bind it. Removed.


> >             case 1:
> > -                   if (keycode >= 0x80)
> > +                   if (keycode == KEY_DC)
> > +                           retval = altdelete;
> > +                   else if (keycode >= 0x80)
> >                             retval = keycode;  
> 
> No, this will not be added either.  <Esc> <Del> will not be equivalent
> to <Alt+Del>, just like <Esc> <Enter> is not equivalent to <Alt+Enter>
> and <Esc> <Down> is not equivalent to <Alt+Down>, and so on.

M-Del doesn't work in urxvt without it.


> > +   else if (retval == altdelete) {
> > +           meta_key = TRUE;
> > +           return ALT_DELETE;  
> 
> Why does 'meta_key' need to be set?  It is not set for the other
> 'ALT_' keystrokes.  Same thing further down.

It doesn't work without it.

New patches at https://savannah.gnu.org/bugs/?54837